-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket subscription for work notifications #2289
Merged
guilhermelawless
merged 6 commits into
nanocurrency:master
from
guilhermelawless:websockets/pow-subscription
Sep 8, 2019
Merged
Websocket subscription for work notifications #2289
guilhermelawless
merged 6 commits into
nanocurrency:master
from
guilhermelawless:websockets/pow-subscription
Sep 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
documentation
This item indicates the need for or supplies updated or expanded documentation
websockets
labels
Sep 6, 2019
…ocal work generation was stopped
cryptocode
approved these changes
Sep 6, 2019
guilhermelawless
requested review from
wezrule
and removed request for
SergiySW
September 8, 2019 08:11
wezrule
approved these changes
Sep 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment to resolve.
guilhermelawless
added a commit
to guilhermelawless/nano-docs
that referenced
this pull request
Sep 23, 2019
- PoW notification nanocurrency/nano-node#2289 - Keepalive nanocurrency/nano-node#2307
guilhermelawless
added a commit
to nanocurrency/nano-docs
that referenced
this pull request
Sep 25, 2019
* Websocket updates - PoW notification nanocurrency/nano-node#2289 - Keepalive nanocurrency/nano-node#2307 * Update advanced.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
This item indicates the need for or supplies updated or expanded documentation
websockets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No filtering options. Examples:
Generated:
Cancelled with one bad peer:
"reason": "failure"
."source": "local"
.Also fixed another issue in
distributed_work
. It got a little out of hand, especially so soon after a refactor, but it's the price to handle work generation locally and through peers, as well as cancelling.