Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows tests for ipc #1663

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix windows tests for ipc #1663

merged 1 commit into from
Jan 30, 2019

Conversation

cryptocode
Copy link
Contributor

Which was actually a string lifetime issue spotted by msvc's iterator debug support.

@cryptocode cryptocode added the bug label Jan 30, 2019
@cryptocode cryptocode added this to the V18.0 milestone Jan 30, 2019
@cryptocode cryptocode self-assigned this Jan 30, 2019
@cryptocode cryptocode requested a review from wezrule January 30, 2019 09:00
@wezrule
Copy link
Contributor

wezrule commented Jan 30, 2019

Working for me now, good job!

@cryptocode cryptocode merged commit a40cb66 into nanocurrency:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

Assignees

@cryptocode cryptocode

Labels
bug
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptocode @wezrule