Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wallet_history consistency with other RPC #1654

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Improve wallet_history consistency with other RPC #1654

merged 1 commit into from
Jan 28, 2019

Conversation

SergiySW
Copy link
Contributor

wallet_account --> block_account
And prevent history for change blocks (like in RPC account_history)

@SergiySW
Improve wallet_history consistency with other RPC
54d28f7 
wallet_account --> block_account
And prevent history for change blocks
@SergiySW SergiySW added this to the V18.0 milestone Jan 28, 2019
@SergiySW SergiySW self-assigned this Jan 28, 2019
@SergiySW SergiySW requested a review from cryptocode January 28, 2019 15:18
cryptocode
cryptocode approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergiySW SergiySW merged commit 598e8a3 into nanocurrency:master Jan 28, 2019
@zhyatt zhyatt added the functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality label Jan 30, 2019
@zhyatt zhyatt added rpc Changes related to Remote Procedure Calls and removed rpc nonbreaking change labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality rpc Changes related to Remote Procedure Calls
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SergiySW @cryptocode @zhyatt