Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new swap method to verify_state_blocks () #1566

Closed

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Jan 8, 2019

For max_count = 256 || 2048 items.push_back (state_blocks.front ()) becoming more effective around (state_blocks.size () > 4 * max_count)
Following #1475

For max_count = 256 || 2048 items.push_back (state_blocks.front ()) becoming more effective around (state_blocks.size () > 4 * max_count)
Following nanocurrency#1475
@SergiySW SergiySW added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Jan 8, 2019
@SergiySW SergiySW added this to the V18.0 milestone Jan 8, 2019
@SergiySW SergiySW self-assigned this Jan 8, 2019
@SergiySW SergiySW requested review from rkeene and cryptocode January 8, 2019 14:13
@SergiySW
Copy link
Contributor Author

Closing in favor of #1571
New swap nethod not required if check state blocks existence before inserting to items deque

@SergiySW SergiySW closed this Jan 14, 2019
@zhyatt zhyatt removed this from the V18.0 milestone Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants