Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of contact timestamping drops peers #1536

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

cryptocode
Copy link
Contributor

@cryptocode cryptocode commented Jan 2, 2019

No description provided.

@zhyatt zhyatt added the incomplete This item is incomplete and should not be merged if it is a pull request label Jan 2, 2019
@zhyatt zhyatt added this to the Research for Future Release milestone Jan 2, 2019
@cryptocode cryptocode added enhancement experiment This item indicates that the change is an experiment and is not fully baked and removed incomplete This item is incomplete and should not be merged if it is a pull request labels Jan 3, 2019
@clemahieu
Copy link
Contributor

Can we get a test to show last_contact_info being updated correctly?

@cryptocode
Copy link
Contributor Author

Yeah, will look into a test

@clemahieu clemahieu merged commit 4dc6682 into nanocurrency:master Jan 7, 2019
@rkeene rkeene requested a review from clemahieu January 7, 2019 22:53
@rkeene rkeene removed the experiment This item indicates that the change is an experiment and is not fully baked label Jan 7, 2019
@zhyatt zhyatt modified the milestones: V18.0, V17.1 Jan 16, 2019
rkeene pushed a commit that referenced this pull request Jan 17, 2019
* Lack of contact timestamping drops peers

* Added test to make sure last_contact is updated
@cryptocode cryptocode deleted the fix/dropped-peers branch January 18, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants