Faster block existence check when the block type is known #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeene
added
enhancement
experiment
SergiySW
reviewed
Dec 18, 2018
| @@ -217,7 +217,7 @@ void ledger_processor::state_block (rai::state_block const & block_a) | |||
| void ledger_processor::state_block_impl (rai::state_block const & block_a) | |||
| { | |||
| auto hash (block_a.hash ()); | |||
| auto existing (ledger.store.block_exists (transaction, hash)); | |||
| auto existing (ledger.store.block_exists (transaction, block_a.type (), hash)); | |||
There was a problem hiding this comment.
Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state
There was a problem hiding this comment.
Yeah, I couldn't decide on that :)
There was a problem hiding this comment.
I think it'll be okay -- we can always change it if it shows up in profiling
rkeene
removed
the
experiment
|
Another experiment gone right. Good job ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1483,
block_exists (stateblock)is the next function that shows up in the profiling ofprocess_receive_one. Currently when checking state blocks, four other tables are checked first. With this, the correct table is checked directly if the block type is known. The currentblock_exists(where the block type is unknown) is reimplemented in terms of the new one.Part of #1478