Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI --debug_profile_votes #1366

Merged
merged 9 commits into from
Nov 30, 2018
Merged

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Nov 9, 2018

To check vote_processor speed

To check vote_processor speed
@rkeene rkeene requested a review from argakiig November 9, 2018 14:43
@rkeene rkeene added this to the V18.0 milestone Nov 9, 2018
@rkeene
Copy link
Contributor

rkeene commented Nov 19, 2018

Can we split this into two different pull requests -- one with the --debug_profile_votes and the other with the changes to timing ?

@SergiySW
Copy link
Contributor Author

Yes. But probably CLI will not return correct results with 100k ms delay

@rkeene
Copy link
Contributor

rkeene commented Nov 23, 2018

Seems reasonable

Missing a close parentheses, other than that we'll merge it:

/workspace/rai/node/node.cpp: In member function 'void rai::active_transactions::announce_loop()':
/workspace/rai/node/node.cpp:3090:91: error: expected ')' before ';' token
   condition.wait_for (lock, std::chrono::milliseconds (announce_interval_ms + extra_delay);
                                                                                           ^

@rkeene rkeene merged commit 8ddc581 into nanocurrency:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants