Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC "sign" (hash, block) #1241

Merged
merged 35 commits into from
Jan 28, 2019
Merged

RPC "sign" (hash, block) #1241

merged 35 commits into from
Jan 28, 2019

Conversation

SergiySW
Copy link
Contributor

Allowing to sign hash or block with private key

@SergiySW SergiySW requested a review from rkeene September 27, 2018 02:01
@SergiySW SergiySW changed the title RPC "sign" RPC "sign_hash" & "sign_block" Sep 27, 2018
@rkeene rkeene added this to the V17.0 milestone Sep 27, 2018
@cryptocode
Copy link
Contributor

cryptocode commented Sep 27, 2018 •
edited
Loading

Instead of two separate actions, could this be a single general action (kind of like #647) so it can be used to sign anything? The message can be a block or hash, but also whatever the caller wants.

@SergiySW
Copy link
Contributor Author

SergiySW commented Sep 27, 2018 •
edited
Loading

It was initially (hash & block in one RPC "sign", later may be messages). But @rkeene don't like it

@rkeene
Copy link
Contributor

rkeene commented Oct 9, 2018

Let's move this to V18.0 for now so we can figure out what semantics are best !

@rkeene rkeene modified the milestones: V17.0, V18.0 Oct 9, 2018
@SergiySW SergiySW changed the title RPC "sign_hash" & "sign_block" RPC "sign" (hash, block) Jan 17, 2019
@rkeene
Copy link
Contributor

rkeene commented Jan 24, 2019

Gives some UBSan errors /home/rkeene/devel/nano-node/nano/lib/jsonconfig.hpp:241:17: runtime error: load of value 110, which is not a valid value for type 'bool'

@SergiySW
Copy link
Contributor Author

@rkeene hopefully fixed

rkeene
rkeene reviewed Jan 24, 2019
View reviewed changes
nano/node/rpc.cpp Outdated Show resolved Hide resolved
rkeene
rkeene approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SergiySW SergiySW merged commit a2fb99e into nanocurrency:master Jan 28, 2019
@Onefox Onefox mentioned this pull request Mar 1, 2019
Closed
This was referenced Mar 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeene rkeene rkeene approved these changes

Assignees

@SergiySW SergiySW

Labels
enhancement
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @cryptocode @rkeene @zhyatt