List of rolled back blocks in block_processor #1158
Conversation
|
We can't filter out blocks that have been forced out because the winner can oscillate before quorum. |
|
If winner will be changed before quorum it will be placed in forced deque, not regular blocks. So ongoing election won't be affected, only fresh bootstrap blocks cannot start same election again & again |
|
That makes sense. So this is to prevent the same block from starting an election if it's already failed once. Should we add every hash that's not the winner at the end of an election in to this set? We need to consider how big we should allow this container to get and when we want to prune it. |
|
Rolling back is very rare event (mostly during initial sync), so I think it's safe here without extra checks |
|
I think better move this to 18.0 |
|
No significant bootstrap speed improvements, proposed to close |
|
We addressed this in other ways, closing this out. |
No description provided.