Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receive_hash option for the blocks_info RPC #3701

Closed
Exxenoz opened this issue Jan 31, 2022 · 0 comments · Fixed by #3702
Closed

Add receive_hash option for the blocks_info RPC #3701

Exxenoz opened this issue Jan 31, 2022 · 0 comments · Fixed by #3702

Comments

@Exxenoz
Copy link
Contributor

Exxenoz commented Jan 31, 2022

Summary

There is currently no easy/fast way to find the corresponding receive block of a specific send block by using the available RPCs. The only method I could think of is to request ALL blocks of the receiving account and iterate through them, which sounds like something that should be rather done on node side than on client side; due to performance reasons.

This issue could be solved by adding a receive_hash option to the blocks_info RPC. In contrast to the source_account option (which adds the address of the send block to its corresponding receive block), the receive_hash option would add the hash of the receive block to its corresponding send block.

What problem would be solved by this feature?

Complicated additional client processing logic to find receive blocks by their send block hash could/should be avoided as well as unnecessary HTTP traffic and resulting delays.

Are there any previous requests for this feature?

Not that I'm aware of.

Do you have a suggested solution?

Yes.

If this feature is approved, would you be willing to submit a pull request with the solution?

I would

Possible solution

I will create a PR.

Supporting files

No response

qwahzi added a commit to qwahzi/nano-docs-1 that referenced this issue Jan 24, 2023
thsfs pushed a commit to nanocurrency/nano-docs that referenced this issue Jan 26, 2023
* Add receive_hash documentation for blocks_info RPC

Adding receive_hash details per nanocurrency/nano-node#3701

* Add back the line break

Co-authored-by: Thiago Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant