Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary json serializing of config files #3530

Closed
zhyatt opened this issue Oct 26, 2021 · 0 comments · Fixed by #3655
Closed

Remove unnecessary json serializing of config files #3530

zhyatt opened this issue Oct 26, 2021 · 0 comments · Fixed by #3655
Labels
non-functional change

Comments

@zhyatt
Copy link
Collaborator

zhyatt commented Oct 26, 2021

With previous .json config files being replaced in V20.0 with .toml files, we kept the related nano::logging::serialize_json code to support upgrade paths from V19.0 forward. But now that V19.0 is an inactive release we should verify this serialization code and other code related to processing .json config files is removed and cleaned up.
cryptocode added a commit to cryptocode/raiblocks that referenced this issue Jan 6, 2022
@cryptocode
Remove json config code
b497c2b 
This improves compile/test times a bit. The json->toml upgrade paths are removed as well. In the unlikely case someone needs to upgrade from v19.x and earlier, the solution is to run a v2x node (prior to this change) to perform the upgrade.

Closes nanocurrency#3530
@cryptocode cryptocode mentioned this issue Jan 6, 2022
Merged
clemahieu pushed a commit that referenced this issue Jan 12, 2022
@cryptocode
Remove json config code (#3655)
016f15b 
* Remove json config code

This improves compile/test times a bit. The json->toml upgrade paths are removed as well. In the unlikely case someone needs to upgrade from v19.x and earlier, the solution is to run a v2x node (prior to this change) to perform the upgrade.

Closes #3530

* Remove stat_config json deserialization as well

* Remove stat_config header's deserialize_json and jsonconfig::read_and_update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
non-functional change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove json config code cryptocode/raiblocks
1 participant
@zhyatt