Skip to content

Commit

Permalink
Disable intermittently failing unit tests (#3526)
Browse files Browse the repository at this point in the history
  • Loading branch information
theohax authored Oct 26, 2021
1 parent 5042967 commit 782ea18
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
5 changes: 4 additions & 1 deletion nano/core_test/election.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,10 @@ TEST (election, quorum_minimum_confirm_fail)

namespace nano
{
TEST (election, quorum_minimum_update_weight_before_quorum_checks)
// Test disabled because it's failing intermittently.
// PR in which it got disabled: https://github.com/nanocurrency/nano-node/pull/3526
// Issue for investigating it: https://github.com/nanocurrency/nano-node/issues/3528
TEST (election, DISABLED_quorum_minimum_update_weight_before_quorum_checks)
{
nano::system system;
nano::node_config node_config (nano::get_available_port (), system.logging);
Expand Down
5 changes: 4 additions & 1 deletion nano/core_test/node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3159,7 +3159,10 @@ TEST (node, epoch_conflict_confirm)
}
}

TEST (node, fork_invalid_block_signature)
// Test disabled because it's failing intermittently.
// PR in which it got disabled: https://github.com/nanocurrency/nano-node/pull/3526
// Issue for investigating it: https://github.com/nanocurrency/nano-node/issues/3527
TEST (node, DISABLED_fork_invalid_block_signature)
{
nano::system system;
nano::node_flags node_flags;
Expand Down
2 changes: 1 addition & 1 deletion nano/node/online_reps.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class online_reps final
nano::uint128_t online_m;
nano::uint128_t minimum;

friend class election_quorum_minimum_update_weight_before_quorum_checks_Test;
friend class election_DISABLED_quorum_minimum_update_weight_before_quorum_checks_Test;
friend std::unique_ptr<container_info_component> collect_container_info (online_reps & online_reps, std::string const & name);
};

Expand Down

0 comments on commit 782ea18

Please sign in to comment.