Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow adding keyless evars #544

Closed
glinton opened this issue Aug 22, 2017 · 0 comments
Closed

Don't allow adding keyless evars #544

glinton opened this issue Aug 22, 2017 · 0 comments
Assignees
@glinton

Comments

@glinton
Copy link
Contributor

glinton commented Aug 22, 2017 

$ nanobox evar add local = 

✓  added

$ nanobox evar ls local

Environment Variables
   = 


$ nanobox evar rm local " "

✓   removed

$ nanobox evar ls local

Environment Variables
   = 

$ nanobox evar rm local ""


$ nanobox evar ls local

Environment Variables
   =
glinton added a commit that referenced this issue Aug 22, 2017
@glinton
Enhance added evars validation
de89ea2 
Don't allow keyless evars. Resolves #544
Discontinue lodaing file contents as value on `evar add`. Resolves #545
Support for arbitrary strings as environment variable values. Resolves #541
  - We no longer split on commas, thus supporting all (bash/etc.. valid) values
@glinton glinton mentioned this issue Aug 22, 2017
Merged
@glinton glinton self-assigned this Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glinton glinton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glinton