275817 - Use i18n islet resource #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-brousse
requested changes
Oct 11, 2023
There was a problem hiding this comment.
@MBausson I've to check a bit more, but here is my first review
MBausson
force-pushed
the
275817-i18n-islet-resource
branch
from
0c3b0cb to
4c07a96
Compare
nicolas-brousse
requested changes
Oct 11, 2023
There was a problem hiding this comment.
@MBausson some cleans to do. I've to think a bit more for export_button to be sure of the direction we'll took
MBausson
force-pushed
the
275817-i18n-islet-resource
branch
from
be4a98d to
a2a2076
Compare
MBausson
force-pushed
the
275817-i18n-islet-resource
branch
2 times, most recently
from
d43a894 to
c806911
Compare
MBausson
force-pushed
the
275817-i18n-islet-resource
branch
from
c806911 to
864024b
Compare
nicolas-brousse
requested changes
Dec 6, 2023
MBausson
force-pushed
the
275817-i18n-islet-resource
branch
from
eff974d to
3415823
Compare
nicolas-brousse
requested changes
Dec 6, 2023
MBausson
commented
Dec 6, 2023
added 10 commits
December 13, 2023 15:55
nicolas-brousse
force-pushed
the
275817-i18n-islet-resource
branch
from
d50bfd3 to
1792dec
Compare
nicolas-brousse
added a commit
to pantographe/my-dcim
that referenced
this pull request
Dec 20, 2023
Co-authored-by: Maximilien Bausson <[email protected]> Co-authored-by: Nicolas Brousse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.