275817 - i18n - Use i18n for memory type resource #110
+58
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-brousse
requested changes
Nov 22, 2023
There was a problem hiding this comment.
@MBausson you forgot to move string for controller flash messages
| @@ -1,4 +1,7 @@ | |||
| <%= render 'layouts/breadcrumb', breadcrumb_variables: {'Paramètres' => modeles_url, 'Memory type' => ''} %> | |||
| <%= render 'layouts/breadcrumb', breadcrumb_variables: { | |||
| t("breadcrumb.settings") => modeles_url, | |||
There was a problem hiding this comment.
Suggested change
| t("breadcrumb.settings") => modeles_url, | |
| t("inventories") => modeles_url, |
app/views/memory_types/new.html.erb
Outdated
| 'Paramètres' => modeles_url, | ||
| 'Types de RAM' => memory_types_path, | ||
| "Nouveau type de RAM" => '', | ||
| t("breadcrumb.settings") => modeles_url, |
There was a problem hiding this comment.
Suggested change
| t("breadcrumb.settings") => modeles_url, | |
| t("inventories") => modeles_url, |
MBausson
force-pushed
the
275817-i18n-memory-types-resource
branch
from
e53691c to
35e34cb
Compare
nicolas-brousse
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.