Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typedefs): add type definitions to the project #44

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ZachHaber
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This sets up typescript definition support for the project allowing typescript users to use the library and improving documentation by putting the docs inside the IDE.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ZachHaber ZachHaber changed the title Feat(typedefs): add type definitions to the project feat(typedefs): add type definitions to the project Nov 29, 2023
@ZachHaber
Copy link
Contributor Author

Note: This includes the types set up for #43. To remove those types, the VNode parts can be removed from ToastBody so it is defined as string only.

@nandi95 nandi95 merged commit 4de4ed8 into nandi95:v1 Nov 29, 2023
@ZachHaber ZachHaber deleted the v1-typedefs branch November 29, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants