libmcount: support no-plt binary #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoKyuWon
commented
Sep 1, 2023
|
I need to refresh my memory on this. Please expect some delays.. |
ChoKyuWon
force-pushed
the
master
branch
3 times, most recently
from
4b712b5 to
cd2f88c
Compare
namhyung
reviewed
Sep 5, 2023
| @@ -93,6 +93,7 @@ int arch_load_dynsymtab_noplt(struct uftrace_symtab *dsymtab, struct uftrace_elf | |||
| pr_dbg3("[%zd] %c %lx + %-5u %s\n", dsymtab->nr_sym, sym->type, sym->addr, | |||
| sym->size, sym->name); | |||
| } | |||
| sort_dynsymtab(dsymtab); | |||
There was a problem hiding this comment.
I think this change can be applied separately.
There was a problem hiding this comment.
Oh, actually I meant the sort_dynsymtab() only. I think you can split the changes in the following way.
- add
sort_dynsymtab()at the end ofarch_load_dynsymtab_noplt(). It's an independent issue and can go separately. - add
arch_load_dynsymtab_noplt()toload_dynsymtab(). This should have no effect to normal PLT binaries. - check PLT with additional skip symbols and read from
.rela.dyn.
ChoKyuWon
force-pushed
the
master
branch
6 times, most recently
from
2561230 to
4893696
Compare
ChoKyuWon
force-pushed
the
master
branch
2 times, most recently
from
73dda35 to
ad939be
Compare
namhyung
reviewed
Sep 16, 2023
|
|
||
| for (size_t i = 0; i < jmprel_nr; i += (is_rela ? sizeof(Elf64_Rela) : sizeof(Elf64_Rel))) { | ||
| bool found = false; | ||
| Elf64_Rela *rel = (void *)jmprel_addr + i; |
There was a problem hiding this comment.
I prefer having a blank line after the declaration.
ChoKyuWon
force-pushed
the
master
branch
2 times, most recently
from
028f43b to
5ad537b
Compare
namhyung
reviewed
Sep 17, 2023
Issue reported that no-plt binary is handled as plt-enable binary because some functions are still left in plt section. The patch fixes this bug by comparing the name of self with a list of known functions. Fixes: namhyung#1777 Signed-off-by: ChoKyuWon <[email protected]>
`load_dynsymtab` only loaded the dynamic symbols from `dynsym` and PLTs(`.rel(a).plt` and `.plt`). this commit fixes it to call the `arch_load_dynsymtab_noplt` in the `load_dynsymtab`, so it also loads the dynamic symbols from the `rel(a).dyn`, which normally saves the symbols in case of no-plt option. Signed-off-by: ChoKyuWon <[email protected]>
|
Sorry about the long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1777 reported that no-plt binary is handled as plt-enable binary because some functions are still left in plt section. The patch fixes this bug by comparing the name of self with a list of known functions.