Channel and connection refactor #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use timeout for initial client connection - use timeout for send/recv on client and server connection sockets - wait for connections to stop before stopping server channel (via new serverconnectionpool) - use context manager to track connection dead-ness
(we were running the test with a compatible server and the wrong label)
otherwise they try to reconnect as the server is being stopped and produce a traceback in the logs
generate the error as part of the stream rather than afterwards, so that close is only called once
(entrypoint edition)
- ensure all streams are closed on exit - simpler error handling, catching all exceptions - nicer thread idents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of changes in this dev branch that ran for longer than intended:
stoppedevent; fixes a bug where clients could deadlock after connection failuresStream.close()is now idempotent -- required because many different codepaths now call it, and they race.ServerChannel: just refactors code out of theEntrypointClientChannel: