added omniauth to app #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reneesandefur Thanks! Will merge it soon! |
| @@ -15,3 +15,6 @@ | |||
| /log/* | |||
| !/log/.keep | |||
| /tmp | |||
|
|
|||
| # secrets.yml backup | |||
| config/secrets_backup.yml | |||
There was a problem hiding this comment.
Please add one more line at the end so that this red mark could be removed.
| @@ -51,3 +51,4 @@ group :development do | |||
| gem 'spring' | |||
| end | |||
|
|
|||
| gem 'omniauth-facebook' | |||
|
@reneesandefur I think it would be good if we can also take user profile picture? Feel free to open an issue for that and start working on it in different pr. |
|
Added the lines. I will create the issue for the image shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the FB dev page I used localhost. I assume you want control over your own FB dev account so all that should be necessary is plugging in your own app id, password and adding the web address for callback to the dev account. Let me know what changes need to be made.