Check RN 0.59.0 and 0.59.1

naluri-hidup · Apr 19, 2019 · e6d0bc2 · e6d0bc2
1 parent 4e27ddb
commit e6d0bc2
Show file tree

Hide file tree

Showing 6 changed files with 147 additions and 20 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,10 +5,10 @@ stages:
     if: branch = master OR type = pull_request
 
 env:
- global:
-  - SYS=22
-  - ABI="default;armeabi-v7a"
-  - ADB_INSTALL_TIMEOUT=10 # minutes
+  global:
+    - SYS=22
+    - ABI="default;armeabi-v7a"
+    - ADB_INSTALL_TIMEOUT=10 # minutes
 
 _integration_job_template: &integration_job_template
   stage: integration
@@ -92,33 +92,72 @@ matrix:
         - npm test
 
     # Integration tests for different React Native versions
+
     - <<: *android_job_template
-      name: 'Integrate with RN 0.57.2 Android'
-      env: RN_VERSION=0.57.2
+      name: 'Integrate with RN 0.59.1 Android'
+      env: RN_VERSION=0.59.1
     - <<: *ios_job_template
-      name: 'Integrate with RN 0.57.2 iOS'
-      env: RN_VERSION=0.57.2
+      name: 'Integrate with RN 0.59.1 iOS'
+      env: RN_VERSION=0.59.1
+
     - <<: *android_job_template
-      name: 'Integrate with RN 0.57.5 Android'
-      env: RN_VERSION=0.57.5
+      name: 'Integrate with RN 0.59.0 Android'
+      env: RN_VERSION=0.59.0
     - <<: *ios_job_template
-      name: 'Integrate with RN 0.57.5 iOS'
-      env: RN_VERSION=0.57.5
+      name: 'Integrate with RN 0.59.0 iOS'
+      env: RN_VERSION=0.59.0
+
     - <<: *android_job_template
-      name: 'Integrate with RN 0.57.8 Android'
-      env: RN_VERSION=0.57.8
+      name: 'Integrate with RN 0.58.3 Android'
+      env: RN_VERSION=0.58.3
     - <<: *ios_job_template
-      name: 'Integrate with RN 0.57.8 iOS'
-      env: RN_VERSION=0.57.8
+      name: 'Integrate with RN 0.58.3 iOS'
+      env: RN_VERSION=0.58.3
+
     - <<: *android_job_template
       name: 'Integrate with RN 0.58.0 Android'
       env: RN_VERSION=0.58.0
     - <<: *ios_job_template
       name: 'Integrate with RN 0.58.0 iOS'
       env: RN_VERSION=0.58.0
+
     - <<: *android_job_template
-      name: 'Integrate with RN 0.58.3 Android'
-      env: RN_VERSION=0.58.3
+      name: 'Integrate with RN 0.57.8 Android'
+      env: RN_VERSION=0.57.8
     - <<: *ios_job_template
-      name: 'Integrate with RN 0.58.3 iOS'
-      env: RN_VERSION=0.58.3
+      name: 'Integrate with RN 0.57.8 iOS'
+      env: RN_VERSION=0.57.8
+
+    - <<: *android_job_template
+      name: 'Integrate with RN 0.57.5 Android'
+      env: RN_VERSION=0.57.5
+    - <<: *ios_job_template
+      name: 'Integrate with RN 0.57.5 iOS'
+      env: RN_VERSION=0.57.5
+
+    - <<: *android_job_template
+      name: 'Integrate with RN 0.57.2 Android'
+      env: RN_VERSION=0.57.2
+    - <<: *ios_job_template
+      name: 'Integrate with RN 0.57.2 iOS'
+      env: RN_VERSION=0.57.2
+
+    - <<: *android_job_template
+      name: 'Integrate with RN 0.56.1 Android'
+      env: RN_VERSION=0.56.1
+    - <<: *ios_job_template
+      name: 'Integrate with RN 0.56.1 iOS'
+      env: RN_VERSION=0.56.1
+
+    - <<: *android_job_template
+      name: 'Integrate with RN 0.55.4 Android'
+      env: RN_VERSION=0.55.4
+    - <<: *ios_job_template
+      name: 'Integrate with RN 0.55.4 iOS'
+      env: RN_VERSION=0.55.4
+
+  allow_failures:
+    - name: 'Integrate with RN 0.55.4 Android'
+    - name: 'Integrate with RN 0.55.4 iOS'
+    - name: 'Integrate with RN 0.56.1 Android'
+    - name: 'Integrate with RN 0.56.1 iOS'
diff --git a/README.md b/README.md
@@ -23,6 +23,22 @@ What this library does NOT support:
 - communicating between phones using BLE (Peripheral support)
 - [bonding peripherals](https://github.com/Polidea/react-native-ble-plx/wiki/Device-Bonding)
 
+## Compatibility
+
+| React Native | 1.0.3              |
+| ------------ | ------------------ |
+| 0.59.1       | :white_check_mark: |
+| 0.59.0       | :white_check_mark: |
+| 0.58.3       | :white_check_mark: |
+| 0.58.0       | :white_check_mark: |
+| 0.57.8       | :white_check_mark: |
+| 0.57.5       | :white_check_mark: |
+| 0.57.2       | :white_check_mark: |
+| 0.56.1       | :boom:<sup>1</sup> |
+| 0.55.4       | :boom:<sup>1</sup> |
+
+<sup>1</sup> fails on Android, although might work after updating gradle
+
 ## Recent Changes
 
 **1.0.3**

diff --git a/integration-tests/patches/rn-0.59.0/0001-minSdkVersion-bump.patch b/integration-tests/patches/rn-0.59.0/0001-minSdkVersion-bump.patch
@@ -0,0 +1,13 @@
+diff --git a/integration-tests/Setup/android/build.gradle b/integration-tests/Setup/android/build.gradle
+index c6e7c7c..24b752a 100644
+--- a/integration-tests/Setup/android/build.gradle
++++ b/integration-tests/Setup/android/build.gradle
+@@ -3,7 +3,7 @@
+ buildscript {
+     ext {
+         buildToolsVersion = "28.0.3"
+-        minSdkVersion = 16
++        minSdkVersion = 18
+         compileSdkVersion = 28
+         targetSdkVersion = 28
+         supportLibVersion = "28.0.0"
diff --git a/integration-tests/patches/rn-0.59.0/0002-gradle-espresso-config.patch b/integration-tests/patches/rn-0.59.0/0002-gradle-espresso-config.patch
@@ -0,0 +1,23 @@
+diff --git a/integration-tests/Setup/android/app/build.gradle b/integration-tests/Setup/android/app/build.gradle
+index 1f01fa3..207d72c 100644
+--- a/integration-tests/Setup/android/app/build.gradle
++++ b/integration-tests/Setup/android/app/build.gradle
+@@ -103,6 +103,7 @@ android {
+         targetSdkVersion rootProject.ext.targetSdkVersion
+         versionCode 1
+         versionName "1.0"
++        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+     }
+     splits {
+         abi {
+@@ -138,6 +139,10 @@ dependencies {
+     implementation fileTree(dir: "libs", include: ["*.jar"])
+     implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
+     implementation "com.facebook.react:react-native:+"  // From node_modules
++    testImplementation 'junit:junit:4.12'
++    androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
++    androidTestImplementation 'androidx.test:runner:1.1.0'
++    androidTestImplementation 'androidx.test:rules:1.1.0'
+ }
+
+ // Run this once to be able to run the application with BUCK
diff --git a/integration-tests/patches/rn-0.59.1/0001-minSdkVersion-bump.patch b/integration-tests/patches/rn-0.59.1/0001-minSdkVersion-bump.patch
@@ -0,0 +1,13 @@
+diff --git a/integration-tests/Setup/android/build.gradle b/integration-tests/Setup/android/build.gradle
+index c6e7c7c..24b752a 100644
+--- a/integration-tests/Setup/android/build.gradle
++++ b/integration-tests/Setup/android/build.gradle
+@@ -3,7 +3,7 @@
+ buildscript {
+     ext {
+         buildToolsVersion = "28.0.3"
+-        minSdkVersion = 16
++        minSdkVersion = 18
+         compileSdkVersion = 28
+         targetSdkVersion = 28
+         supportLibVersion = "28.0.0"
diff --git a/integration-tests/patches/rn-0.59.1/0002-gradle-espresso-config.patch b/integration-tests/patches/rn-0.59.1/0002-gradle-espresso-config.patch
@@ -0,0 +1,23 @@
+diff --git a/integration-tests/Setup/android/app/build.gradle b/integration-tests/Setup/android/app/build.gradle
+index 1f01fa3..207d72c 100644
+--- a/integration-tests/Setup/android/app/build.gradle
++++ b/integration-tests/Setup/android/app/build.gradle
+@@ -103,6 +103,7 @@ android {
+         targetSdkVersion rootProject.ext.targetSdkVersion
+         versionCode 1
+         versionName "1.0"
++        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+     }
+     splits {
+         abi {
+@@ -138,6 +139,10 @@ dependencies {
+     implementation fileTree(dir: "libs", include: ["*.jar"])
+     implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
+     implementation "com.facebook.react:react-native:+"  // From node_modules
++    testImplementation 'junit:junit:4.12'
++    androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
++    androidTestImplementation 'androidx.test:runner:1.1.0'
++    androidTestImplementation 'androidx.test:rules:1.1.0'
+ }
+
+ // Run this once to be able to run the application with BUCK