Skip to content

Commit

Permalink
Add 0.59.3 also
Browse files Browse the repository at this point in the history
  • Loading branch information
Piotr Dubiel authored and Cierpliwy committed Apr 19, 2019
1 parent 47c5e6a commit 0232acf
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,13 @@ matrix:

# Integration tests for different React Native versions

- <<: *android_job_template
name: 'Integrate with RN 0.59.3 Android'
env: RN_VERSION=0.59.3
- <<: *ios_job_template
name: 'Integrate with RN 0.59.3 iOS'
env: RN_VERSION=0.59.3

- <<: *android_job_template
name: 'Integrate with RN 0.59.1 Android'
env: RN_VERSION=0.59.1
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ What this library does NOT support:

| React Native | 1.0.3 |
| ------------ | ------------------ |
| 0.59.3 | :white_check_mark: |
| 0.59.1 | :white_check_mark: |
| 0.59.0 | :white_check_mark: |
| 0.58.3 | :white_check_mark: |
Expand Down
13 changes: 13 additions & 0 deletions integration-tests/patches/rn-0.59.3/0001-minSdkVersion-bump.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/integration-tests/Setup/android/build.gradle b/integration-tests/Setup/android/build.gradle
index c6e7c7c..24b752a 100644
--- a/integration-tests/Setup/android/build.gradle
+++ b/integration-tests/Setup/android/build.gradle
@@ -3,7 +3,7 @@
buildscript {
ext {
buildToolsVersion = "28.0.3"
- minSdkVersion = 16
+ minSdkVersion = 18
compileSdkVersion = 28
targetSdkVersion = 28
supportLibVersion = "28.0.0"
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
diff --git a/integration-tests/Setup/android/app/build.gradle b/integration-tests/Setup/android/app/build.gradle
index 1f01fa3..207d72c 100644
--- a/integration-tests/Setup/android/app/build.gradle
+++ b/integration-tests/Setup/android/app/build.gradle
@@ -103,6 +103,7 @@ android {
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
versionName "1.0"
+ testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}
splits {
abi {
@@ -138,6 +139,10 @@ dependencies {
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
implementation "com.facebook.react:react-native:+" // From node_modules
+ testImplementation 'junit:junit:4.12'
+ androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
+ androidTestImplementation 'androidx.test:runner:1.1.0'
+ androidTestImplementation 'androidx.test:rules:1.1.0'
}

// Run this once to be able to run the application with BUCK

0 comments on commit 0232acf

Please sign in to comment.