Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove redundant cargo build step from README #16

Merged
merged 1 commit into from
Apr 25, 2023
Merged

docs: remove redundant cargo build step from README #16

merged 1 commit into from
Apr 25, 2023

Conversation

eightfilms
Copy link
Contributor

@eightfilms eightfilms commented Apr 25, 2023 •
edited
Loading

cargo install will always use the release profile by default, and installing from --path will always build and install, so we don't have to build it in a separate step.

nalinbhardwaj
nalinbhardwaj approved these changes Apr 25, 2023
View reviewed changes
Copy link
Owner

@nalinbhardwaj nalinbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@nalinbhardwaj nalinbhardwaj merged commit 1bc7e39 into nalinbhardwaj:main Apr 25, 2023
@eightfilms eightfilms deleted the update-readme branch April 26, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalinbhardwaj nalinbhardwaj nalinbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eightfilms @nalinbhardwaj