Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Chenged some files #17

Merged
merged 3 commits into from
Sep 5, 2021
Merged

[change] Chenged some files #17

merged 3 commits into from
Sep 5, 2021

Conversation

urasakikeisuke
Copy link
Collaborator

@urasakikeisuke urasakikeisuke commented Sep 5, 2021 •
edited
Loading

Pull Request Type

  • change

Description

Removed unnecessary task and added some ci badges

Pre-Review Checklist for the Pull Request Author

  • Code follows coding-guidelines
  • Assign Pull Request to reviewer

Checklist for the Pull Request Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding-guidelines
  • (Optional) Unit tests have been written for new behavior
  • Pull Request title describes the changes

Post-Review Checklist for the Pull Request Author

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@urasakikeisuke urasakikeisuke added the change Just little changes label Sep 5, 2021
@urasakikeisuke urasakikeisuke self-assigned this Sep 5, 2021
nakajima-john-shotaro
nakajima-john-shotaro approved these changes Sep 5, 2021
View reviewed changes
Copy link
Owner

@nakajima-john-shotaro nakajima-john-shotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.🙃
By the way, do you want to talk about my job not getting finished?

.github/workflows/codeql-analysis.yml
@@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
language: [ ]
language: [ 'python' ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javascriptは入れなくても大丈夫？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解しました。

@nakajima-john-shotaro nakajima-john-shotaro merged commit c6ba1ab into main Sep 5, 2021
@nakajima-john-shotaro nakajima-john-shotaro deleted the develop/circleci branch September 5, 2021 13:37
@urasakikeisuke
Copy link
Collaborator Author

@nakajima-john-shotaro https://github.com/nakajima-john-shotaro/AIcon_dev/milestone/1

@urasakikeisuke
Copy link
Collaborator Author

@nakajima-john-shotaro A human being can live for 11 days without sleep.

@urasakikeisuke urasakikeisuke restored the develop/circleci branch September 6, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakajima-john-shotaro nakajima-john-shotaro nakajima-john-shotaro approved these changes

Assignees

@urasakikeisuke urasakikeisuke

Labels
change Just little changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urasakikeisuke @nakajima-john-shotaro