Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop/develop #128

Merged
merged 19 commits into from
Oct 8, 2021
Merged

Develop/develop #128

merged 19 commits into from
Oct 8, 2021

Conversation

nakajima-john-shotaro
Copy link
Owner

Pull Request Type

  • 🐛 fix : (bug fix for the user, not a fix to a build script)
  • 🩹 change : (simple fix for a non-critical issue)
  • feat : (new feature for the user, not a new feature for build script)
  • 📝 docs : (changes to the documentation)
  • ♻️ refactor : (refactoring production code, eg. renaming a variable)
  • ✏️ style : (formatting, missing semi colons, etc; no production code change)
  • 🚨 test : (adding missing tests, refactoring tests; no production code change)
  • 📦 chore : (updating grunt tasks etc; no production code change)
  • reverts : (canceling commits or pull requests)

Description

Add support for checking devices..

Pre-Review Checklist for the Pull Request Author

  • Code follows coding-guidelines
  • Assign Pull Request to reviewer

Checklist for the Pull Request Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding-guidelines
  • (Optional) Unit tests have been written for new behavior
  • Pull Request title describes the changes

Post-Review Checklist for the Pull Request Author

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@nakajima-john-shotaro nakajima-john-shotaro added enhancement New feature or request change Just little changes backend Backend related frontend Frontend related labels Oct 8, 2021
@nakajima-john-shotaro nakajima-john-shotaro self-assigned this Oct 8, 2021
@nakajima-john-shotaro nakajima-john-shotaro merged commit 4710c5b into main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related change Just little changes enhancement New feature or request frontend Frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants