Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/docker #12

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Fix/docker #12

merged 2 commits into from
Sep 3, 2021

Conversation

urasakikeisuke
Copy link
Collaborator

Pull Request Type

  • change

Description

Changed Dockerfile for deepl

Pre-Review Checklist for the Pull Request Author

  • Code follows coding-guidelines
  • Assign Pull Request to reviewer

Checklist for the Pull Request Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding-guidelines
  • (Optional) Unit tests have been written for new behavior
  • Pull Request title describes the changes

Post-Review Checklist for the Pull Request Author

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@urasakikeisuke urasakikeisuke added the enhancement New feature or request label Sep 3, 2021
@urasakikeisuke urasakikeisuke self-assigned this Sep 3, 2021
nakajima-john-shotaro
nakajima-john-shotaro approved these changes Sep 3, 2021
View reviewed changes
Copy link
Owner

@nakajima-john-shotaro nakajima-john-shotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGIF👍
BtsBangtanBoysGIF

aicon/backend/runme.py
) -> None:
super().__init__()

if translator in ["google", "deepl"]:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

独自の翻訳AIを咬ませると面白そうですね。

aicon/backend/runme.py
output_text = self.g_translator.translate(text, src=lang, dest="en").text
else:
output_text = text
print(output_text)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここのPrintは消しましょう。

@nakajima-john-shotaro nakajima-john-shotaro merged commit 9e9f8f9 into main Sep 3, 2021
@nakajima-john-shotaro nakajima-john-shotaro deleted the fix/docker branch September 3, 2021 12:22
@urasakikeisuke urasakikeisuke restored the fix/docker branch September 3, 2021 22:54
@urasakikeisuke urasakikeisuke mentioned this pull request Sep 3, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakajima-john-shotaro nakajima-john-shotaro nakajima-john-shotaro approved these changes

Assignees

@urasakikeisuke urasakikeisuke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urasakikeisuke @nakajima-john-shotaro