Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/backend/image #106

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Feature/backend/image #106

merged 3 commits into from
Oct 3, 2021

Conversation

urasakikeisuke
Copy link
Collaborator

Pull Request Type

  • 🐛 fix : (bug fix for the user, not a fix to a build script)
  • 🩹 change : (simple fix for a non-critical issue)
  • ✨ feat : (new feature for the user, not a new feature for build script)
  • 📝 docs : (changes to the documentation)
  • ♻️ refactor : (refactoring production code, eg. renaming a variable)
  • ✏️ style : (formatting, missing semi colons, etc; no production code change)
  • 🚨 test : (adding missing tests, refactoring tests; no production code change)
  • 📦 chore : (updating grunt tasks etc; no production code change)
  • ⏪ reverts : (canceling commits or pull requests)

Description

Fixed tensor shape bugs.

Pre-Review Checklist for the Pull Request Author

  • Code follows coding-guidelines
  • Assign Pull Request to reviewer

Checklist for the Pull Request Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding-guidelines
  • (Optional) Unit tests have been written for new behavior
  • Pull Request title describes the changes

Post-Review Checklist for the Pull Request Author

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@urasakikeisuke urasakikeisuke added change Just little changes backend Backend related hotfix Important bug fix labels Oct 2, 2021
@urasakikeisuke urasakikeisuke self-assigned this Oct 2, 2021
nakajima-john-shotaro
nakajima-john-shotaro approved these changes Oct 3, 2021
View reviewed changes
Copy link
Owner

@nakajima-john-shotaro nakajima-john-shotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am grateful for your support.

aicon/backend/server.py
@@ -57,7 +57,7 @@
_lock: Lock = Lock()
_twitter_database: Dict[str, str] = {}

_translator: Translation = Translation("deepl")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なぜ、Deeplを諦めたのですか？
非常に興味深いです。

@nakajima-john-shotaro nakajima-john-shotaro merged commit 2789457 into develop/develop Oct 3, 2021
@nakajima-john-shotaro nakajima-john-shotaro deleted the feature/backend/image branch October 3, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakajima-john-shotaro nakajima-john-shotaro nakajima-john-shotaro approved these changes

Assignees

@urasakikeisuke urasakikeisuke

Labels
backend Backend related change Just little changes hotfix Important bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urasakikeisuke @nakajima-john-shotaro