fix(controllers): return early when adding finalizer

nais · Dec 20, 2024 · 0fc003f · 0fc003f
1 parent d558418
commit 0fc003f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/controllers/jwker_controller.go b/controllers/jwker_controller.go
@@ -229,10 +229,13 @@ func (r *JwkerReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl
 	}
 
 	if !controllerutil.ContainsFinalizer(&jwker, finalizer) {
-		controllerutil.AddFinalizer(&jwker, finalizer)
-		if err := r.Client.Update(ctx, &jwker); err != nil {
+		if err := r.updateJwker(ctx, jwker, func(existing *jwkerv1.Jwker) error {
+			controllerutil.AddFinalizer(existing, finalizer)
+			return r.Update(ctx, existing)
+		}); err != nil {
 			return ctrl.Result{}, fmt.Errorf("registering finalizer: %w", err)
 		}
+		return ctrl.Result{}, nil
 	}
 
 	hash, err = jwker.Spec.Hash()