feat(finalizer): don't create events for add/remove operations

These events are somewhat spammy and not really actionable anyway.
nais · Oct 3, 2023 · 40ee100 · 40ee100
1 parent 673ecf2
commit 40ee100
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/pkg/reconciler/finalizer/finalizer.go b/pkg/reconciler/finalizer/finalizer.go
@@ -57,7 +57,6 @@ func (f finalizer) register(tx transaction.Transaction) error {
 		return fmt.Errorf("error when registering finalizer: %w", err)
 	}
 
-	f.ReportEvent(tx, corev1.EventTypeNormal, v1.EventAddedFinalizer, "Object finalizer is added")
 	return nil
 }
 
@@ -90,7 +89,6 @@ func (f finalizer) finalize(tx transaction.Transaction) error {
 		return fmt.Errorf("failed to remove finalizer from list: %w", err)
 	}
 
-	f.ReportEvent(tx, corev1.EventTypeNormal, v1.EventDeletedFinalizer, "Object finalizer is deleted")
 	metrics.IncWithNamespaceLabel(metrics.AzureAppsDeletedCount, tx.Instance.Namespace)
 
 	return nil