feat: fix tests

nahid18 · Oct 12, 2023 · 840c8d1 · 840c8d1
1 parent cec1165
commit 840c8d1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: easylift
 Title: An R package to perform genomic liftover
-Version: 0.99.97
-Date: 2023-09-25
+Version: 0.99.98
+Date: 2023-10-12
 Authors@R: 
     c(
     person("Abdullah", "Al Nahid", email= "[email protected]", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-4390-0768")),

diff --git a/README.Rmd b/README.Rmd
@@ -87,7 +87,7 @@ gr |> easylift("hg38")
 To cite package `easylift` in publications use:
 
   Al Nahid A, Pagès H, Love M (2023). _easylift: An R package to perform
-  genomic liftover_. R package version 0.99.97,
+  genomic liftover_. R package version 0.99.98,
   <https://github.com/nahid18/easylift>.
 
 
@@ -98,7 +98,7 @@ A BibTeX entry for LaTeX users is
     title = {easylift: An R package to perform genomic liftover},
     author = {Abdullah Al Nahid, Hervé Pagès, Michael Love},
     year = {2023},
-    note = {R package version 0.99.97},
+    note = {R package version 0.99.98},
     url = {https://github.com/nahid18/easylift},
   }
 ```

diff --git a/README.md b/README.md
@@ -84,7 +84,7 @@ gr |> easylift("hg38")
 To cite package `easylift` in publications use:
 
 Al Nahid A, Pagès H, Love M (2023). *easylift: An R package to perform
-genomic liftover*. R package version 0.99.97,
+genomic liftover*. R package version 0.99.98,
 <https://github.com/nahid18/easylift>.
 
 A BibTeX entry for LaTeX users is
@@ -93,7 +93,7 @@ A BibTeX entry for LaTeX users is
         title = {easylift: An R package to perform genomic liftover},
         author = {Abdullah Al Nahid, Hervé Pagès, Michael Love},
         year = {2023},
-        note = {R package version 0.99.97},
+        note = {R package version 0.99.98},
         url = {https://github.com/nahid18/easylift},
       }
 

diff --git a/tests/testthat/test-easylift.R b/tests/testthat/test-easylift.R
@@ -33,8 +33,6 @@ test_that("easylift function tests with valid chain files", {
 
   expect_no_error(easylift(gr2, "hg38"))
   expect_no_error(gr2 |> easylift("hg38"))
-  expect_no_error(gr2 |> easylift("hg38", NULL, NULL))
-  expect_no_error(gr2 |> easylift("hg38", NULL))
 })
 
 test_that("easylift function tests with error cases", {
@@ -100,6 +98,8 @@ test_that("easylift succeeds with BiocFileCache", {
   expect_error(easylift(gr, "hg38", bfc))
   expect_error(gr |> easylift("hg38", bfc))
   expect_no_error(easylift(gr, "hg38", NULL, bfc))
+  expect_no_error(gr |> easylift("hg38", NULL, NULL))
+  expect_no_error(gr |> easylift("hg38", NULL))
 
   # Test success when bfc is provided
   tryCatch({