Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowkey Vault Docker does not support dynamic host ports - URI validation #1321

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

nagyesta
Copy link
Owner

Issue: #1319

Description

  • Adds better URI validation to filter out invalid host names
  • Updates tests
  • Updates documentation

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

- Adds better URI validation to filter out invalid host names
- Updates tests
- Updates documentation

Updates #1319
{patch}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta added the enhancement New feature or request label Jan 18, 2025
@nagyesta nagyesta self-assigned this Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.85%. Comparing base (23c7b26) to head (46d9d50).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../github/nagyesta/lowkeyvault/AppConfiguration.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1321      +/-   ##
============================================
- Coverage     98.89%   98.85%   -0.04%     
- Complexity     2034     2036       +2     
============================================
  Files           239      239              
  Lines          4976     4982       +6     
  Branches        197      198       +1     
============================================
+ Hits           4921     4925       +4     
- Misses           42       43       +1     
- Partials         13       14       +1     
Flag Coverage Δ
app 99.32% <75.00%> (-0.05%) ⬇️
client 94.00% <ø> (ø)
testcontainers 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit 039093e into main Jan 18, 2025
13 of 14 checks passed
@nagyesta nagyesta deleted the feature/better-validate-uris branch January 18, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant