-
Notifications
You must be signed in to change notification settings - Fork 0
Home
nagupta92 edited this page Aug 1, 2019
·
5 revisions
Welcome to the interview-wiki wiki!
Questions to ask in a Pull Request review Here are the questions I look to give or get in a code review. There are probably more good questions, but these are the ones I find most important. These questions might also help determine whom the reviewer(s) should be for each PR:
-
Does it solve the problem as defined in the ticket?
-
Does it fit into the overall application architecture?
-
Is it well architected as a whole?
-
Does it follow best practices?
-
Is the syntax correct?
-
Does it improve or less the maintainability of the code base?
-
Is it inline with — or does it enhance — the branding and styles?
Front End UI questions -
- React vs. Angular - https://programmingwithmosh.com/react/react-vs-angular/
- Testing Frameworks - Cypress, Selenium, Nightwatch, Mocha, Chai,
- Analytics tools - google Analytics, AWS data lakes analytics
- React js Flux Architecture - https://scotch.io/tutorials/getting-to-know-flux-the-react-js-architecture
- React JS - Component, State, Props -https://micropyramid.com/blog/understanding-reactjs-component-state-props/
- What is State in Angular — Still needs to answer
- How React works - https://medium.com/@vigowebs/frequently-asked-react-js-interview-questions-and-answers-36f3dd99f486
- Deploy React Application - https://aws.amazon.com/es/getting-started/tutorials/deploy-react-app-cicd-amplify/
- Running Angular application - ng serve
- What is Transpilling - Process of converting ts files to js.
- Exploring async / Await in jS - Still needs to find answer. - https://alligator.io/js/async-functions/