Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes your package compatible with the next version of dplyr:
case_when()
andif_else()
now use vctrs, which generally makes them more permissive when there are varying types, but it resulted in two issues here:case_when()
can now only return vector types, which was the intention from the beginning. It was returning expressions in one of your use cases, but could easily be replaced with aswitch()
na_of_type()
function vec_ptype2(<character>, <character>) r-lib/vctrs#1300. It is easier to just usex[NA_integer_]
as a generic way to get the same thing in a way that vctrs is okay with. More importantly, in the dev version of dplyr you can just useNA
so you won't need to worry about this at all after 1.1.0 is released! But for now we need the way I've done it to be compatible with dev and CRAN dplyr.We plan to submit dplyr 1.1.0 on January 27th.
This should be compatible with both dev and CRAN dplyr. It would help us out if you could go ahead and send a patch version of your package in ahead of time! Thanks!