Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptography requirements to be <42 instead? #610

Closed
jauderho opened this issue Jul 23, 2023 · 3 comments
Closed

Bump cryptography requirements to be <42 instead? #610

jauderho opened this issue Jul 23, 2023 · 3 comments

Comments

@jauderho
Copy link

When I build sslyze, GitHub scans complains that I'm not using a 41.0.x version. Bumping to 41.0.x should line up with pyopenssl constraints of cryptography!=40.0.0, !=40.0.1, <42 and >=38.0.0

sslyze/setup.py

Line 102 in fccf7f9

"cryptography>=2.6,<40",

@nabla-c0d3
Copy link
Owner

Fixed in v5.2.0.

@mig5
Copy link

mig5 commented Oct 16, 2023

Note that pyOpenSSL locked cryptography to "cryptography>=38.0.0,<42,!=40.0.0,!=40.0.1" until PyOpenSSL version 23.2.0 (see https://github.com/pyca/pyopenssl/pull/1221/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7), so this still fails to install if the version of PyOpenSSL installed is lower than that (you only have a dependency on the major version).

I had to add an explicit dependency on pyOpenSSL>=23.2.0 before I could get cryptography 41.0.4 and sslyze 5.2.0 to install together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants