module: zstd: check we don't leak symbols; regenerate symbol map

Closes: openzfs#12988 Co-authored-by: Rich Ercolani <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli · Mar 13, 2022 · ee92729 · ee92729
1 parent 76bcffb
commit ee92729
Show file tree

Hide file tree

Showing 3 changed files with 338 additions and 380 deletions.
diff --git a/Makefile.am b/Makefile.am
@@ -103,7 +103,7 @@ endif
 endif
 
 PHONY += codecheck
-codecheck: cstyle shellcheck checkbashisms flake8 mancheck testscheck vcscheck
+codecheck: cstyle shellcheck checkbashisms flake8 mancheck testscheck vcscheck zstdcheck
 
 PHONY += checkstyle
 checkstyle: codecheck commitcheck
@@ -164,6 +164,10 @@ vcscheck:
 		awk '{c++; print} END {if(c>0) exit 1}' ; \
 	fi
 
+PHONY += zstdcheck
+zstdcheck:
+	@$(MAKE) -C module/zstd checksymbols
+
 PHONY += lint
 lint: cppcheck paxcheck
 

diff --git a/module/zstd/Makefile.in b/module/zstd/Makefile.in
@@ -62,3 +62,8 @@ $(MODULE)-objs += $(vanilla-objs)
 all:
 	mkdir -p lib/common lib/compress lib/decompress
 
+gensymbols:
+	@OBJDUMP@ -t $(vanilla-objs) | awk '/file format/ {print ""; print "/* " $$1 " */"; next}  $$2 == "g" && !/ zfs_/ {print "#define\t" $$6 " zfs_" $$6}' >> include/zstd_compat_wrapper.h
+
+checksymbols:
+	@OBJDUMP@ -t $(vanilla-objs) | awk '/file format/ {print}  $$2 == "g" && !/ zfs_/ {++ret; print}  END {exit ret}'