Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change nw binary path for linux #1

Merged
merged 1 commit into from
Aug 30, 2014

Conversation

pirog
Copy link

@pirog pirog commented Aug 30, 2014

If you are running karma tests in travis ci the "browser" will stay open and hang the build. This happens even with singleRun set to true. If you use the actual linux binary the browser closes after tests as expected.

I'm not sure what other implications this has so i submit this to you for all the criticisms!

nDmitry added a commit that referenced this pull request Aug 30, 2014
change nw binary path for linux
@nDmitry nDmitry merged commit 250f3c9 into nDmitry:master Aug 30, 2014
@nDmitry
Copy link
Owner

nDmitry commented Aug 30, 2014

I'm not sure what other implications this has

Neither am I, but other paths don't use a symlink in the .bin/ folder, so I merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants