Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flaky code node switching test #13090

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Feb 6, 2025

Summary

The test runs fine locally but is flaky on CICD, even with waits.

Removed the 2nd edit to make it stable

Related Linear tickets, Github issues, and Community forum posts

Introduced here:

#13078

https://linear.app/n8n/issue/NODE-2358/code-node-overwrites-code-when-switching-nodes-after-edits

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit df89c6f into master Feb 6, 2025
37 checks passed
@elsmr elsmr deleted the fix-flaky-code-node-e2e branch February 6, 2025 10:38
elsmr added a commit that referenced this pull request Feb 6, 2025
@janober
Copy link
Member

janober commented Feb 6, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants