fix(GitHub Node): Don't truncate filenames retrieved from GitHub #12923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariana-na
changed the title
Mariana-na
force-pushed
the
NODE2164-filepath-incomplete-after-question-mark
branch
from
c36a2b7 to
4cbac83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
dana-gill
approved these changes
Jan 31, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
NODE2164-filepath-incomplete-after-question-mark
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Dana Lee |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
432
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Mariana-na
deleted the
NODE2164-filepath-incomplete-after-question-mark
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows returned files from GitHub to maintain full filename when they have a question mark, instead of truncating them.
To test: Set GitHub noe to GET file. Fetch a file with a question mark (?) in the filename.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2164/github-node-special-character-in-file-path-is-ignored-and-path-is
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)