fix(editor): Refine push modal layout #12886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
r00gm
commented
Jan 29, 2025
packages/editor-ui/package.json
Outdated
There was a problem hiding this comment.
needed for polyfiling Set methods in node < 22
There was a problem hiding this comment.
Corejs is adding the polys only when they're missing, no need for conditions
netroy
requested changes
Jan 29, 2025
packages/editor-ui/src/components/SourceControlPushModal.ee.test.ts
Outdated
Show resolved
Hide resolved
cstuncsik
approved these changes
Jan 29, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-2384-refine-layout-of-commit-screen-when-both-workflows-and-other
|
| Run status |
|
| Run duration | 04m 34s |
| Commit |
|
| Committer | Csaba Tuncsik |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
432
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
cstuncsik
approved these changes
Jan 29, 2025
|
|
|
✅ All Cypress E2E specs passed |
netroy
approved these changes
Jan 29, 2025
|
✅ All Cypress E2E specs passed |
r00gm
deleted the
pay-2384-refine-layout-of-commit-screen-when-both-workflows-and-other
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
PAY-2384
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)