Ado-2898-execute-workflow-node-add-workflow-inputs-parameter

[igatanasov]

Summary

• Added new backend endpoint and load context for workflow parameters.
• Updated resource mapper component to load workflow input mapper.
• Extracted common logic from the execute workflow trigger node and reused it in the execute workflow node.

TODO:

• Add constant values for field mapping and field expressions in follow up PR for this issue - https://linear.app/n8n/issue/ADO-2898/execute-workflow-node-add-workflow-inputs-parameter
• Add tests in a follow-up PR.

Video: https://www.loom.com/share/06bdad96daa24e83809ebbe4191915d5

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2950/add-resource-mapper-option-to-handle-workflow-inputs

https://linear.app/n8n/issue/ADO-2898/execute-workflow-node-add-workflow-inputs-parameter

Review / Merge checklist

• PR title and summary are descriptive. (conventions)
• Docs updated or follow-up ticket created.
• Tests included.
• PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[codecov]

Codecov Report

Attention: Patch coverage is 21.07438% with 191 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...des-base/nodes/ExecuteWorkflow/GenericFunctions.ts	9.37%	58 Missing ⚠️
...xecuteWorkflow/ExecuteWorkflow/GenericFunctions.ts	0.00%	27 Missing ⚠️
...de-execution-context/local-load-options-context.ts	14.28%	24 Missing ⚠️
...teWorkflow/ExecuteWorkflow/ExecuteWorkflow.node.ts	0.00%	14 Missing ⚠️
...orkflow/ExecuteWorkflow/methods/resourceMapping.ts	0.00%	13 Missing ⚠️
packages/editor-ui/src/api/nodeTypes.ts	0.00%	11 Missing ⚠️
...i/src/components/ResourceMapper/ResourceMapper.vue	54.54%	10 Missing ⚠️
...li/src/services/dynamic-node-parameters.service.ts	30.76%	8 Missing and 1 partial ⚠️
packages/editor-ui/src/stores/nodeTypes.store.ts	20.00%	8 Missing ⚠️
.../controllers/dynamic-node-parameters.controller.ts	0.00%	4 Missing and 1 partial ⚠️
... and 3 more

📢 Thoughts on this report? Let us know!

[CharlieKolb]

If we need to bump the node version please do so now so we have it in the diff and don't forget about it later. LGTM otherwise.

[igatanasov]

If we need to bump the node version please do so now so we have it in the diff and don't forget about it later. LGTM otherwise.

Thanks @CharlieKolb , nice catch. we have already bump the node version with prev node changes.

[igatanasov]

@netroy this is the branch that I will base the work for workflowInputs

[CharlieKolb]

Just some quick notes since I already wrote them before our call :D

[CharlieKolb]

Left some initial nitpicks, will try the feature now

[CharlieKolb]

Is the actual expression mapping expected to work already? The value I provide is ignored and the inputData is still used directly, unless I'm holding it wrong :D Type version is 1.2, the latest.

[CharlieKolb]

Requesting changes as github UI is bugged and my ancient approval is still repeated on every comment 🙈

[MiloradFilipovic]

Left a minor comment. Will test the feature once more when I pull in the latest changes and leave further comments if I have any

[CharlieKolb]

Looks ready for the feature branch from my side, really nice work handling the complexity 🙌