Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add new table for test metrics (no-changelog) #11848

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

burivuhster
Copy link
Contributor

Summary

This is a part of a TestRunner framework for workflow evaluation.
Metric is just a property name to look for in the output of evaluation workflow.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...atabases/repositories/test-metric.repository.ee.ts 0.00% 6 Missing ⚠️
...kages/cli/src/databases/entities/test-metric.ee.ts 85.71% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@burivuhster burivuhster marked this pull request as ready for review November 22, 2024 13:44
@burivuhster burivuhster requested a review from a team as a code owner November 22, 2024 13:44
Copy link
Collaborator

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

Copy link

cypress bot commented Nov 25, 2024

n8n    Run #8060

Run Properties:  status check passed Passed #8060  •  git commit e5dfae9e77: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-432-db-metric
Run status status check passed Passed #8060
Run duration 04m 45s
Commit git commit e5dfae9e77: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit 459e6aa into master Nov 25, 2024
40 checks passed
@burivuhster burivuhster deleted the ai-432-db-metric branch November 25, 2024 09:38
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants