Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Use a single SVG for logo and favicon (no-changelog) #11811

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 20, 2024

Summary

This PR

  1. Deletes 9 logo variants files
  2. Adds a 2 new SVGs to generate all the variants programatically
  3. Consolidates all logo related code into a single place, and adds tests for it
  4. For non-stable releases, copies over the logo svg into the favicon as well

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 20, 2024
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 🙌🏻
A few points from my side:

  • Can we make this a design-system component? Current implementation includes a few specific things, like releaseChannel and location that we can abstract away and pass color, showLogoText and showReleaseChannelTag as props
  • Maybe also moving logo creation logic from onMounted into a composable would make it easier to mock in the test if there is no other workaround for jsdom issue

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/editor-ui/src/components/Logo/Logo.vue 93.02% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants