feat(Oura Node): Update node for v2 api #11604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1954
|
| Run status |
|
| Run duration | 04m 21s |
| Commit |
|
| Committer | Jonathan Bennetts |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
462
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Got released with |
|
Any chance this can start including stress data or the other data from the api docs? https://cloud.ouraring.com/v2/docs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Oura stopped using the v1 API a while back, This updates the node to use the v2 API. If it wasn't for the v1 API being removed already this normally would be a breaking change.
To test the API you need access to an Oura device which I don't currently have but maybe we can ask a user with a device to confirm. I did add a quick test and based on the API response it looks like it should work.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1954/community-issue-oura-node-uses-removed-v1-api
#11510
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)