Introduce a naming convention option for Etude primary reference #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates Etude::getReference
Add a parameter to Etude.getReference
… in Twig templates
Closed
Stoakes
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 kinds of Junior-Entreprise :
To keep its workflow, M-Gate was willing to maintain its own version, with Etude.reference matching its needs. However, having 2 concurrent versions is a loss of energy. The solution is to introduce an option describing which field should be used as primary reference for an Etude in controllers.
Etude.reference has also been deprecated to point out that it should not be used anymore, especially in doctypes. Instead it should be created manually in doctypes.
To adapt parameter table to test that PR :
docker-compose exec web php bin/console doctrine:migrations:execute 20170603140214@Olivier-R