Fix #20

And bump version number for release. Signed-off-by: Tod Fitch <[email protected]>
n76 · Apr 30, 2019 · 97232a6 · 97232a6
1 parent 816add6
commit 97232a6
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Removed
 - Not applicable
 
+## [1.1.12 - 29-Apr-2019]
+
+### Changed
+- Fix crash prev or next pressed when denied permission to access song storage.
+
 ## [1.1.11 - 04-Apr-2019]
 ### Changed
 - Added privacy policy.

diff --git a/app/build.gradle b/app/build.gradle
@@ -8,8 +8,8 @@ android {
         applicationId "org.fitchfamily.android.symphony"
         minSdkVersion 21
         targetSdkVersion 28
-        versionCode 19
-        versionName "1.1.11"
+        versionCode 20
+        versionName "1.1.12"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 

diff --git a/app/release/app-release.apk b/app/release/app-release.apk
diff --git a/app/release/output.json b/app/release/output.json
@@ -1 +1 @@
-[{"outputType":{"type":"APK"},"apkData":{"type":"MAIN","splits":[],"versionCode":19,"versionName":"1.1.11","enabled":true,"outputFile":"app-release.apk","fullName":"release","baseName":"release"},"path":"app-release.apk","properties":{}}]
+[{"outputType":{"type":"APK"},"apkData":{"type":"MAIN","splits":[],"versionCode":20,"versionName":"1.1.12","enabled":true,"outputFile":"app-release.apk","fullName":"release","baseName":"release"},"path":"app-release.apk","properties":{}}]
diff --git a/app/src/main/java/org/fitchfamily/android/symphony/MainActivity.java b/app/src/main/java/org/fitchfamily/android/symphony/MainActivity.java
@@ -393,16 +393,21 @@ public void songPicked(View view) {
     }
 
     private void playNext() {
-        musicSrv.playNext();
-        startSeekTracking();
-        updateControls();
+        int permissionCheck = ContextCompat.checkSelfPermission(this, Manifest.permission.READ_EXTERNAL_STORAGE);
+        if (permissionCheck == PackageManager.PERMISSION_GRANTED) {
+            musicSrv.playNext();
+            startSeekTracking();
+            updateControls();
+        }
     }
 
     private void playPrev() {
-        Log.d(TAG, "playPrev() entry.");
-        musicSrv.playPrev();
-        startSeekTracking();
-        updateControls();
+        int permissionCheck = ContextCompat.checkSelfPermission(this, Manifest.permission.READ_EXTERNAL_STORAGE);
+        if (permissionCheck == PackageManager.PERMISSION_GRANTED) {
+            musicSrv.playPrev();
+            startSeekTracking();
+            updateControls();
+        }
     }
 
     // Media Controller methods

diff --git a/fastlane/metadata/android/en-US/changelogs/20.txt b/fastlane/metadata/android/en-US/changelogs/20.txt
@@ -0,0 +1 @@
+- Fix crash prev or next pressed when denied permission to access song storage.
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		[{"outputType":{"type":"APK"},"apkData":{"type":"MAIN","splits":[],"versionCode":19,"versionName":"1.1.11","enabled":true,"outputFile":"app-release.apk","fullName":"release","baseName":"release"},"path":"app-release.apk","properties":{}}]
		[{"outputType":{"type":"APK"},"apkData":{"type":"MAIN","splits":[],"versionCode":20,"versionName":"1.1.12","enabled":true,"outputFile":"app-release.apk","fullName":"release","baseName":"release"},"path":"app-release.apk","properties":{}}]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- Fix crash prev or next pressed when denied permission to access song storage.