Get rid of spread operator for prop key #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
key is a special prop in React that's used for reconciliation. React recommends handling it separately from other props.
|
+1 |
1 similar comment
|
+1 |
OmarSaidIbrahim
approved these changes
Nov 21, 2024
|
I've forked and published the fix here: |
|
@JimTeva your MR fixes the issue only for |
|
This seems like an abandoned project, last release was 5 years ago. Anyone planning on creating a new fork that will keep up with RN/react? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key is a special prop in React that's used for reconciliation. React recommends handling it separately from other props.
Generates errors in react-native v75.3 if not handled properly.