Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace icon download logic with a local ico file #5

Closed
wants to merge 5 commits into from

Conversation

amoshydra
Copy link
Contributor

@amoshydra amoshydra commented Aug 1, 2021

Summary

Obtain ico file locally instead of from remote source

The android icon (source) and its corresponding ico file will be stored in this repository.

png2ico dependency has been removed from the list as the ico file will be packaged in the .nupkg

Related issue

This PR aims to resolve checksum mismatch issue with the current android icon fetched from iconfinder

Downloading android
  from 'https://www.iconfinder.com/icons/317758/download/png/128'

Download of android.png (-1 B) completed.
Error - hashes do not match. Actual value was 'D0B659EB903B08B9A67D97257FC10B7C3269581A913E9F72B20D6E890C01D988'.
ERROR: Checksum for 'C:\Users\username\AppData\Local\Temp\chocolatey\android.png' did not meet 'B2FE913ED202C908D10ACD1D602CCDB24E2E79F3009570E2CADAF22694FFA4DA' for checksum type 'sha256'. Consider passing the actual checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
The install of scrcpy was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\scrcpy\tools\chocolateyinstall.ps1'.
 See log for details.

Related conversation / issues:

How is this tested

Tested installation

choco pack
choco install scrcpy -s . -y

Output:
image

Icons in start menu and file explorer

image

@amoshydra
Copy link
Contributor Author

amoshydra commented Aug 2, 2021

The linked icon resource is licensed under Creative Commons (Attribution 3.0 Unported).

In the meantime, would it be better to generate icon.png from the original icon.xpm file instead? https://github.com/Genymobile/scrcpy/blob/v1.18/app/src/icon.xpm

Example

magick convert icon.xpm -filter point -resize 128x128 icon.png

image

@amoshydra
Copy link
Contributor Author

Closing this in favor of #6, which get the icon from https://github.com/Genymobile/scrcpy

@amoshydra amoshydra closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant