Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user id to all logs #134

Merged
merged 1 commit into from
Mar 29, 2023
Merged

add user id to all logs #134

merged 1 commit into from
Mar 29, 2023

Conversation

AlexHTW
Copy link
Contributor

@AlexHTW AlexHTW commented Mar 28, 2023

for better maintainability of users #130

@n3d1117
Copy link
Owner

n3d1117 commented Mar 29, 2023

Cool thanks @AlexHTW. Now that I think about it, should we log usernames instead of names?

@AlexHTW
Copy link
Contributor Author

AlexHTW commented Mar 29, 2023

Ah, good point, I was not aware of the difference!
I think sticking with name is good, because it seems to default to username if one is set.
Username would be empty if the user didn't set one.
https://stackoverflow.com/questions/38532567/telegram-bot-api-username-field-is-missing

@n3d1117
Copy link
Owner

n3d1117 commented Mar 29, 2023

Alright, merging this!

@n3d1117 n3d1117 merged commit 4ed59d2 into n3d1117:main Mar 29, 2023
@AlexHTW AlexHTW deleted the add-user-id-to-log branch April 1, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants