Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useOnResolve rewraps field.resolve when other plugins pass the same fields to replaceSchema #1772

Closed
jonapgar-groupby opened this issue May 18, 2023 · 0 comments · Fixed by #1773
Closed

useOnResolve rewraps field.resolve when other plugins pass the same fields to replaceSchema #1772

jonapgar-groupby opened this issue May 18, 2023 · 0 comments · Fixed by #1773

Comments

@jonapgar-groupby
Copy link
Contributor

I encountered a perplexing issue where I was seeing doubled resolver spans when using the useOpenTelemetry plugin.

The cause was another plugin useDeferStream which calls the replaceSchema function in order to add some directives to the schema.

https://github.com/dotansimha/graphql-yoga/blob/82f5893446e3c55519194a1ca1d784120cbe7098/packages/plugins/defer-stream/src/index.ts#L37-L42

The issue isn't specific to useOpenTelemetry. Any plugin that calls addPlugin(useOnResolve... could potentially end up rewrapping resolvers.
jonapgar-groupby added a commit to jonapgar-groupby/envelop that referenced this issue May 18, 2023
@jonapgar-groupby
fix: prevent double-wrapping of field.resolve fixes n1ru4l#1772
59ed441
jonapgar-groupby added a commit to jonapgar-groupby/envelop that referenced this issue May 18, 2023
@jonapgar-groupby
fix: prevent double-wrapping of field.resolve fixes n1ru4l#1772
b9f0206
jonapgar-groupby added a commit to jonapgar-groupby/envelop that referenced this issue May 18, 2023
@jonapgar-groupby
fix: prevent double-wrapping of field.resolve fixes n1ru4l#1772
1940ea3
@jonapgar-groupby jonapgar-groupby mentioned this issue May 18, 2023
Merged
1 task
jonapgar-groupby added a commit to jonapgar-groupby/envelop that referenced this issue May 18, 2023
@jonapgar-groupby
fix: prevent double-wrapping of field.resolve fixes n1ru4l#1772
f5f4bc1
ardatan pushed a commit that referenced this issue May 22, 2023
@jonapgar-groupby
fix: prevent double-wrapping of field.resolve (#1773)
7066ce9 
* fix: prevent double-wrapping of field.resolve fixes #1772

* fix: useOnResolve double-wrap prevention should be on field not field.resolve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent double-wrapping of field.resolve jonapgar-groupby/envelop
1 participant
@jonapgar-groupby