Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v2 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prepare for v2 #13

wants to merge 1 commit into from

Conversation

sumpygump
Copy link

@sumpygump sumpygump commented Nov 30, 2021

Hi, these modules are great, so I thought I would help get ready for Rack v2

Summary of changes:

  • Bump version to 2.x in plugin.json
  • Add labels for inputs and outputs (part of Rack 2 API is to show details of module items when hovering/right clicking)
  • Add appropriate bypass configuration (defines a passthrough of signal when the module is bypassed)
  • Minor cleanup in a few areas (trailing spaces, correcting indentation)
  • Fix warning with return value in Chorus module (return 0.0f even if input is not connected)

@n0jo
Copy link
Owner

n0jo commented Dec 1, 2021

Very helpful, thanks. I will check and test it a bit.

falkTX added a commit to CardinalModules/rackwindows that referenced this pull request Dec 7, 2021
falkTX added a commit to CardinalModules/rackwindows that referenced this pull request Dec 7, 2021
falkTX added a commit to CardinalModules/rackwindows that referenced this pull request Dec 7, 2021
@daniel-ffm
Copy link

daniel-ffm commented Feb 12, 2022

All modules work fine on linux!
Just move to rack 2 and I was missing Rackwindows in an instant. Love your modules very much <3

@missnightwhore
Copy link

Hello. I have a question. In order to migrate and have this modules in vcv 2 library, should i rename the version inside json file with my curent version aka 2.0.6 and then to copy the folder with the files in documents\rack 2 \ plugins ? is this how could be installed? thanks

@KingKone
Copy link

No, changing the version number in your plugin.json will not help you.
Just follow the instructions on how to build your own modules in the VCV manual.
If you have setup the development environment go on to download and compile
the v2 branch from sumpygump from here https://github.com/sumpygump/rackwindows/tree/v2
If you run linux i can give you the one i have build.

@missnightwhore
Copy link

thanks for the info.
I use windows so I will download the windows files and I will work on building them with vcv tools from the website. cheers for the work for these modules, great useful tools.

@jimallman
Copy link

This compiles and installs nicely on Mac as well, with the usual incantations. I'll leave my steps as a guide to the perplexed Mac user. First, clone this repo to your machine and cd into the repo's top-level directory:

% cd ~/projects/vcv-rack-modules/rackwindows

Make sure you're compiling the v2 branch:

% git checkout v2

Enter a shell that thinks we're running on an Intel Mac:

% arch -x86_64 /bin/bash

Now point to your previously installed SDK folder and run make install:

$ RACK_DIR="/Users/jim/projects/vcv-rack-modules/Rack-SDK 2" make install

This should install RackWindows modules into your local Rack 2. If you see a warning about missing files (probably rack.hpp), you should confirm that RACK_DIR is pointing your SDK 2 folder, and that you haven't used the ~ shortcut here. This will fail, so be sure spell out the path completely and wrap in double quotes to handle spaces!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants