Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid other output between contents when printing #786

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix: Avoid other output between contents when printing #786

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcc07ed
fix: Avoid other output between contents when printing
flub Feb 22, 2023
60f0f9f
thanks clippy
flub Feb 22, 2023
fa7d48a
Fewer conversions as we usually use format! in callsites
flub Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,9 @@ impl OutWriter {
impl OutWriter {
pub async fn println(&self, content: impl AsRef<[u8]>) {
let stderr = &mut *self.stderr.lock().await;
stderr.write_all(content.as_ref()).await.unwrap();
stderr.write_all(b"\n").await.unwrap();
let mut buf: Vec<u8> = content.as_ref().to_vec();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much allocations :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed. But this isn't very critical. We don't output much.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think you could the signature to take a String and just extend that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's nicer indeed. done

buf.extend(b"\n");
stderr.write_all(&buf).await.unwrap();
}
}

Expand Down